Remove globalrouter labs flag#778
Conversation
The global router has graduated from labs to default behavior — it now starts automatically whenever the miren server has cloud auth configured. - Drop the globalrouter entry from pkg/labs/features.yaml and regenerate - Remove the labs.GlobalRouter() gate in components/coordinate - Update labs_test.go to use routeoidc as the representative flag - Drop --labs globalrouter from the blackbox cloud harness; rename restartServerWithGlobalRouter to restartServerWithRegistration since the restart still happens to load registration.json - Add docs/miren-cloud/global-router.md describing the feature Refs MIR-1079
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis pull request removes the Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/docs/miren-cloud/global-router.md`:
- Around line 39-41: The fenced code block in global-router.md lacks a language
identifier causing MD040; update the block fence from ``` to include a language
(e.g., use ```text or another appropriate language) so it becomes ```text and
ensure the inner line "component=globalrouter ... connected to cloud" remains
unchanged to satisfy linting and enable proper highlighting.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 745afdf7-0c98-4368-93a1-d71b78ad81bc
📒 Files selected for processing (7)
blackbox/harness/cloud.gocomponents/coordinate/coordinate.godocs/docs/miren-cloud/global-router.mddocs/sidebars.tspkg/labs/features.yamlpkg/labs/labs.gen.gopkg/labs/labs_test.go
💤 Files with no reviewable changes (2)
- pkg/labs/features.yaml
- pkg/labs/labs.gen.go
| ``` | ||
| component=globalrouter ... connected to cloud | ||
| ``` |
There was a problem hiding this comment.
Add language identifier to the code block.
The fenced code block should specify a language identifier for proper syntax highlighting and linting compliance.
📝 Proposed fix
-```
+```text
component=globalrouter ... connected to cloud
</details>
As per coding guidelines: markdownlint flagged this as MD040 (fenced-code-language).
<!-- suggestion_start -->
<details>
<summary>📝 Committable suggestion</summary>
> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
```suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 39-39: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/docs/miren-cloud/global-router.md` around lines 39 - 41, The fenced code
block in global-router.md lacks a language identifier causing MD040; update the
block fence from ``` to include a language (e.g., use ```text or another
appropriate language) so it becomes ```text and ensure the inner line
"component=globalrouter ... connected to cloud" remains unchanged to satisfy
linting and enable proper highlighting.
1 participant
Summary
globalrouterfrompkg/labs/features.yaml(regenerateslabs.gen.go), removes thelabs.GlobalRouter()gate incomponents/coordinate, and updatespkg/labs/labs_test.goto userouteoidcas the representative flag for the enable/disable/case/all-keyword tests.restartServerWithGlobalRouter→restartServerWithRegistration(the restart still has to happen to loadregistration.json) and dropsDEV_SERVER_FLAGS='--labs globalrouter'.docs/docs/miren-cloud/global-router.mddescribing how the feature works, when it runs, how it interacts with subdomains, and basic troubleshooting; links it from the Miren Cloud sidebar.Notes for Reviewers
MIREN_LABS=globalrouter(or--labs globalrouter) will get a benign "unknown labs feature flag" warning at startup. No behavior change.make lintpasses;pkg/labsandpkg/globalroutertests pass on the host.components/coordinateintegration tests need the dev container's etcd/containerd and were not run locally.Refs MIR-1079
Test plan
make test-blackboxagainst the cloud harness) verifies the global router still connects without the labs flagconnected to cloudappears in logs